Repository navigation
test(e2e): Add a cloudflare-pi-durable end-to-end application - #25022
Merged
JPeer264 merged 3 commits intoOct 8, 2026
Merged
Conversation
JPeer264
added this pull request to stack #25004
October 3, 2026 16:26
Contributor
size-limit report 📦
|
JPeer264
force-pushed
the
jp/pi-durable-cloudflare-e2e
branch
from
October 5, 2026 07:20
259167d to
e5c842b
Compare
JPeer264
removed this pull request from stack #25004
October 5, 2026 07:21
JPeer264
changed the base branch from
jp/pi-durable-e2e
to
jp/cloudflare-skip-pi-tables
October 5, 2026 07:22
JPeer264
added this pull request to stack #25029
October 5, 2026 07:22
JPeer264
force-pushed
the
jp/pi-durable-cloudflare-e2e
branch
2 times, most recently
from
October 5, 2026 11:22
8bfd4a7 to
a095187
Compare
JPeer264
force-pushed
the
jp/pi-durable-cloudflare-e2e
branch
from
October 5, 2026 12:39
a095187 to
ae5a2f8
Compare
JPeer264
force-pushed
the
jp/pi-durable-cloudflare-e2e
branch
from
October 5, 2026 12:46
ae5a2f8 to
bf50db6
Compare
JPeer264
marked this pull request as ready for review
October 5, 2026 12:47
JPeer264
force-pushed
the
jp/pi-durable-cloudflare-e2e
branch
from
October 5, 2026 12:53
bf50db6 to
0059f6c
Compare
JPeer264
force-pushed
the
jp/pi-durable-cloudflare-e2e
branch
from
October 6, 2026 06:59
c57d751 to
0059f6c
Compare
JPeer264
force-pushed
the
jp/pi-durable-cloudflare-e2e
branch
2 times, most recently
from
October 6, 2026 07:55
a528063 to
264b42d
Compare
andreiborza
approved these changes
Oct 6, 2026
andreiborza
left a comment
andreiborza
left a comment
Member
There was a problem hiding this comment.
Could we maybe also send the data to sentry and assert on it to make it truly e2e?
| @@ -0,0 +1,133 @@ | |||
| import { expect, test } from '@playwright/test'; | |||
Member
There was a problem hiding this comment.
l: Let's use constants from sentry conventions as much as possible.
JPeer264
force-pushed
the
jp/pi-durable-cloudflare-e2e
branch
from
October 7, 2026 09:05
264b42d to
80d2a2d
Compare
JPeer264
force-pushed
the
jp/pi-durable-cloudflare-e2e
branch
from
October 7, 2026 11:01
80d2a2d to
80540af
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+75
to
+76
| this.ctx.abort('crash_once resets the Durable Object'); | ||
| throw new Error('The Durable Object did not reset'); |
Contributor
There was a problem hiding this comment.
Bug: The crash_once function unconditionally throws an error after calling ctx.abort(). Since abort() doesn't halt execution, the tool will always fail instead of being reset and replayed.
Severity: MEDIUM
Suggested Fix
Remove the throw new Error('The Durable Object did not reset'); line. The ctx.abort() call is sufficient to trigger the reset, and the subsequent throw prevents the intended replay mechanism from working correctly. The code should simply call this.ctx.abort(...) and then exit the function.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
dev-packages/e2e-tests/test-applications/cloudflare-pi-durable/src/assistant.ts#L75-L76
Potential issue: In the `crash_once` tool, `this.ctx.abort()` is called to schedule a
reset of the Durable Object. However, `ctx.abort()` does not halt synchronous execution,
so the subsequent `throw new Error(...)` is always executed on the first invocation.
This causes the tool's `execute` function to fail with an exception, which is contrary
to the intended "replay-safe" behavior described in the code comments and expected by
the tests. The Node.js equivalent uses `process.exit()`, which correctly terminates the
process. This implementation will likely cause the tool to be marked as failed instead
of being replayed after the reset.
Also affects:
dev-packages/e2e-tests/test-applications/cloudflare-pi-durable/tests/pi-durable.test.ts:100~103
Did we get this right? 👍 / 👎 to inform future reviews.
JPeer264
force-pushed
the
jp/pi-durable-cloudflare-e2e
branch
from
October 7, 2026 13:51
80540af to
a3e202a
Compare
JPeer264
force-pushed
the
jp/pi-durable-cloudflare-e2e
branch
from
October 7, 2026 17:03
a3e202a to
d1084df
Compare
Member
Author
Going to answer as here: #24994 (comment) |
Runs pi-durable in a Durable Object through the PiHarness of the Cloudflare Agents SDK, with @sentry/cloudflare/vite as the only Sentry setup. The tests check the run trace with its chat, execute_tool and provider spans, a throwing tool, and a run that resumes in a new trace after the Durable Object resets during a tool call. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
force-pushed
the
jp/pi-durable-cloudflare-e2e
branch
from
October 8, 2026 11:27
d1084df to
c49ea1b
Compare
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloudflare now hosts pi-durable in Durable Objects through the Agents SDK
PiHarness(changelog). This app runs pi-durable that way, with@sentry/cloudflare/viteas the only Sentry setup. It checks that a prompt becomes aninvoke_agenttrace withchat,execute_tooland providerhttp.clientspans, that a throwing tool is reported on its span, and that a run resumes in a new trace after the Durable Object resets during a tool call. The reset usesctx.abort(), which drops the object like an eviction; the next request starts it again, andPiHarnessresumes pi from its SQLite state.Like
node-pi-durableandcloudflare-think, it calls a real model through OpenRouter, so it is optional. The changelog example uses Workers AI (createAI({ binding: env.AI })), but the AI binding needs a Cloudflare account even in local dev, so that path has a unit test in #24993 instead.This app found a bug that #24993 now fixes:
@sentry/cloudflareinitializes the SDK inside each request, so the client is on the scope of that request only. The task phases ran on a copy of the default scope, had no client, and dropped every pi-durable span and error.🤖 Generated with Claude Code